-
Notifications
You must be signed in to change notification settings - Fork 18.9k
Closed
Labels
area/networkingNetworkingNetworkingarea/networking/d/bridgeNetworkingNetworkingkind/enhancementEnhancements are not bugs or new features but can improve usability or performance.Enhancements are not bugs or new features but can improve usability or performance.status/0-triage
Milestone
Description
Description
@akerouanton noted in #47871 (comment) that this code for SCTP checksum fixup can now be removed ...
moby/libnetwork/drivers/bridge/port_mapping_linux.go
Lines 542 to 560 in 8c2e4ca
| if b.Proto == types.SCTP { | |
| // Linux kernel v4.9 and below enables NETIF_F_SCTP_CRC for veth by | |
| // the following commit. | |
| // This introduces a problem when combined with a physical NIC without | |
| // NETIF_F_SCTP_CRC. As for a workaround, here we add an iptables entry | |
| // to fill the checksum. | |
| // | |
| // https://github.com/torvalds/linux/commit/c80fafbbb59ef9924962f83aac85531039395b18 | |
| args = []string{ | |
| "-p", b.Proto.String(), | |
| "--sport", strconv.Itoa(int(b.Port)), | |
| "-j", "CHECKSUM", | |
| "--checksum-fill", | |
| } | |
| rule := iptRule{ipv: ipv, table: iptables.Mangle, chain: "POSTROUTING", args: args} | |
| if err := programChainRule(rule, "MASQUERADE", enable); err != nil { | |
| return err | |
| } | |
| } |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/networkingNetworkingNetworkingarea/networking/d/bridgeNetworkingNetworkingkind/enhancementEnhancements are not bugs or new features but can improve usability or performance.Enhancements are not bugs or new features but can improve usability or performance.status/0-triage