container with cifs volume and "addr"-option does not start with version 25 #47184
Description
Description
The fix for resolving FQDN with cifs volumes did break the old workaround with the addr-option.
Container that run with v24 does not start with v25.
Even if it is no longer necessary to include the "addr" option, it should still work.
And the documentation still shows the old workaround as necessary:
https://docs.docker.com/storage/volumes/#create-cifssamba-volumes
Reproduce
services:
cifs-test:
image: ubuntu
volumes:
- inputdir:/opt/input
volumes:
inputdir:
driver: local
driver_opts:
type: "cifs"
o: "addr=domain.local,user=${env:user},password=${env:userpw},file_mode=0666,dir_mode=0666,iocharset=utf8"
device: "//dummy-fs/data"
docker compose up
Error response from daemon: error while mounting volume '/var/lib/docker/volumes/jenkins_inputdir/_data': failed to mount local volume: mount //XXX.XXX.XXX.XXX/data:/var/lib/docker/volumes/jenkins_inputdir/_data, data: addr=domain.local,user=,password=,file_mode=0666,dir_mode=0666,iocharset=utf8: invalid argument
Expected behavior
Starting the container with volume as it worked with v24
docker version
Client: Docker Engine - Community
Version: 25.0.0
API version: 1.44
Go version: go1.21.6
Git commit: e758fe5
Built: Thu Jan 18 17:09:49 2024
OS/Arch: linux/amd64
Context: default
Server: Docker Engine - Community
Engine:
Version: 25.0.0
API version: 1.44 (minimum version 1.24)
Go version: go1.21.6
Git commit: 615dfdf
Built: Thu Jan 18 17:09:49 2024
OS/Arch: linux/amd64
Experimental: false
containerd:
Version: 1.6.27
GitCommit: a1496014c916f9e62104b33d1bb5bd03b0858e59
runc:
Version: 1.1.11
GitCommit: v1.1.11-0-g4bccb38
docker-init:
Version: 0.19.0
GitCommit: de40ad0docker info
Client: Docker Engine - Community
Version: 25.0.0
Context: default
Debug Mode: false
Plugins:
buildx: Docker Buildx (Docker Inc.)
Version: v0.12.1
Path: /usr/libexec/docker/cli-plugins/docker-buildx
compose: Docker Compose (Docker Inc.)
Version: v2.24.1
Path: /usr/libexec/docker/cli-plugins/docker-compose
Server:
Containers: 49
Running: 49
Paused: 0
Stopped: 0
Images: 27
Server Version: 25.0.0
Storage Driver: overlay2
Backing Filesystem: extfs
Supports d_type: true
Using metacopy: false
Native Overlay Diff: true
userxattr: false
Logging Driver: json-file
Cgroup Driver: systemd
Cgroup Version: 2
Plugins:
Volume: local
Network: bridge host ipvlan macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
Swarm: inactive
Runtimes: io.containerd.runc.v2 runc
Default Runtime: runc
Init Binary: docker-init
containerd version: a1496014c916f9e62104b33d1bb5bd03b0858e59
runc version: v1.1.11-0-g4bccb38
init version: de40ad0
Security Options:
apparmor
seccomp
Profile: builtin
cgroupns
Kernel Version: 6.2.0-39-generic
Operating System: Ubuntu 22.04.3 LTS
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 50.91GiB
Docker Root Dir: /var/lib/docker
Debug Mode: false
Experimental: false
Insecure Registries:
127.0.0.0/8
Live Restore Enabled: falseAdditional Info
To successfully start the above compose with version 25, the option "addr" must be removed and the FQDN must be used inside device