-
Notifications
You must be signed in to change notification settings - Fork 18.9k
Closed
Labels
area/storageImage StorageImage Storagecontainerd-integrationIssues and PRs related to containerd integrationIssues and PRs related to containerd integrationkind/refactorPR's that refactor, or clean-up codePR's that refactor, or clean-up code
Description
Description
- relates to c8d: Use reference counting while mounting a snapshot #45698
- relates to c8d: mark stargz as requiring reference-counted mounts #45781
- relates to c8d: mark stargz as requiring reference-counted mounts #45781 (comment)
- slightly related to c8d: docker info "storage driver" section should provide more details #46757
Commit 21c0a54 (#45698) introduced a hard-coded list of snapshotters (refCountedFileSystems) that we know need reference-counting. With containerd, the list of available snapshotters is not known (additional snapshotters may be installed on the system), so maintaining a hard-coded list is problematic to maintain.
moby/daemon/snapshotter/mount.go
Lines 15 to 16 in 54fcd40
| // List of known filesystems that can't be re-mounted or have shared layers | |
| var refCountedFileSystems = []string{"fuse-overlayfs", "overlayfs", "stargz", "zfs"} |
We should consider to either;
- unconditionally use reference-counting (as suggested in c8d: mark stargz as requiring reference-counted mounts #45781 (comment))
- get this information from the snapshotter (also related: c8d: docker info "storage driver" section should provide more details #46757)
- ☝️ this may depend on containerd 2.0 though, so perhaps we need to go for the alternative in the meantime
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/storageImage StorageImage Storagecontainerd-integrationIssues and PRs related to containerd integrationIssues and PRs related to containerd integrationkind/refactorPR's that refactor, or clean-up codePR's that refactor, or clean-up code