CI: Windows RS5 fails on compile errors, but doesn't print the error #40069
Description
I ran into this a couple of times, and recalled that RS1 acts different than RS5 on these; Windows RS5 hides compilation errors, which makes it difficult to find problems in pull requests.
Here's from #40062:
Failure on Windows RS5
? github.com/docker/docker/pkg/plugingetter [no test files]
ok github.com/docker/docker/pkg/plugins 35.063s coverage: 73.4% of statements
....
ERROR: make.ps1 failed:
Unit tests failed
At C:\gopath\src\github.com\docker\docker\hack\make.ps1:324 char:32
+ if ($LASTEXITCODE -ne 0) { Throw "Unit tests failed" }
Same failure on Windows RS1:
? github.com/docker/docker/pkg/plugingetter [no test files]
powershell.exe : # github.com/docker/docker/testutil/daemon
At D:\gopath\src\github.com\docker\docker@tmp\durable-9a15b210\powershellWrapper.ps1:3 char:1
+ & powershell -NoProfile -NonInteractive -ExecutionPolicy Bypass -Comm ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (# github.com/do...testutil/daemon :String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError
testutil\daemon\daemon.go:221:25: cannot use d (type *Daemon) as type string in argument to cleanupNetworkNamespace
ok github.com/docker/docker/pkg/plugins 35.163s coverage: 73.4% of statements
.....
ERROR: make.ps1 failed:
Unit tests failed
At C:\gopath\src\github.com\docker\docker\hack\make.ps1:324 char:32
+ if ($LASTEXITCODE -ne 0) { Throw "Unit tests failed" }
Note that both report all unit tests as ok (passing), but Windows RS5 hides the compile error