Skip to content

TestExecResizeImmediatelyAfterExecStart ignores all errors except EOF #36354

New issue
New issue
Closed
#37172
Closed
TestExecResizeImmediatelyAfterExecStart ignores all errors except EOF#36354
#37172
Labels
area/testing
@dnephin

Description

@dnephin
dnephin
opened on Feb 19, 2018

moby/integration-cli/docker_api_exec_resize_test.go

Lines 68 to 79 in 733ed2d

_, rc, err := request.Post(fmt.Sprintf("/exec/%s/resize?h=24&w=80", execID), request.ContentType("text/plain"))
// It's probably a panic of the daemon if io.ErrUnexpectedEOF is returned.
if err == io.ErrUnexpectedEOF {
return fmt.Errorf("The daemon might have crashed.")
}
if err == nil {
rc.Close()
}
// We only interested in the io.ErrUnexpectedEOF error, so we return nil otherwise.
return nil

This test should be rewritten to test the success case of resize after start, instead of a specific regression that is unlikely to happen ever again.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/testing

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions