-
Notifications
You must be signed in to change notification settings - Fork 18.9k
Closed
Labels
area/apiAPIAPIkind/enhancementEnhancements are not bugs or new features but can improve usability or performance.Enhancements are not bugs or new features but can improve usability or performance.
Description
Description
Docker attach API do use application/vnd.docker.raw-stream content type, which has two implementations:
- multiplexed stdout/stderr streams
- raw tty output
from API response there's no way (afaict) to determine which one is used
I suggest a header is introduced to document which mode is being used
Steps to reproduce the issue:
- ask a friend to create a container, setting tty= to a random value kept secret
- invoke containers/{id}/attach
- try to guess the raw.stream format in use
Describe the results you received:
have to try parsing a multiplexed frame, then admit I was wrong.
Describe the results you expected:
simple way to determine the parsing logic to use
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/apiAPIAPIkind/enhancementEnhancements are not bugs or new features but can improve usability or performance.Enhancements are not bugs or new features but can improve usability or performance.