-
Notifications
You must be signed in to change notification settings - Fork 18.9k
Open
Labels
area/apiAPIAPIkind/enhancementEnhancements are not bugs or new features but can improve usability or performance.Enhancements are not bugs or new features but can improve usability or performance.status/needs-attentionCalls for a collective discussion during a review sessionCalls for a collective discussion during a review session
Milestone
Description
The responsible of the client package is to transform a go struct into an HTTP request, perform the HTTP request, and convert the HTTP response into a go struct + error.
client/service_update.go and client/service_create.go have a bunch of application logic that does not belong in this package. We should remove it and move it into a separate package.
It looks like this logic was first introduced in #32388 and subsequently updated in #33239, and #33575.
This is related to #34242 and docker/cli#386
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/apiAPIAPIkind/enhancementEnhancements are not bugs or new features but can improve usability or performance.Enhancements are not bugs or new features but can improve usability or performance.status/needs-attentionCalls for a collective discussion during a review sessionCalls for a collective discussion during a review session