Skip to content

Remove application logic from client/ package #34268

@dnephin

Description

@dnephin

The responsible of the client package is to transform a go struct into an HTTP request, perform the HTTP request, and convert the HTTP response into a go struct + error.

client/service_update.go and client/service_create.go have a bunch of application logic that does not belong in this package. We should remove it and move it into a separate package.

It looks like this logic was first introduced in #32388 and subsequently updated in #33239, and #33575.

This is related to #34242 and docker/cli#386

cc @thaJeztah @nishanttotla @aaronlehmann

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/apiAPIkind/enhancementEnhancements are not bugs or new features but can improve usability or performance.status/needs-attentionCalls for a collective discussion during a review session

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions