Skip to content

Flaky test TestRestartAutoRemoveContainer/TestRunRmAndWait #29641

@tonistiigi

Description

@tonistiigi

These tests are flaky after error checking was added in #29224

The issue is that there is no way to know when daemon side --rm finishes. This could be issue for regular users as well.

DockerSuite.TestRunReuseBindVolumeThatIsSymlink	1.203s
15:35:15 
15:35:15 ----------------------------------------------------------------------
15:35:15 FAIL: check_test.go:47: DockerSuite.TearDownTest
15:35:15 
15:35:15 check_test.go:49:
15:35:15     deleteAllContainers(c)
15:35:15 docker_utils.go:207:
15:35:15     c.Assert(err, checker.IsNil)
15:35:15 ... value *errors.errorString = &errors.errorString{s:"\nCommand: /go/src/github.com/docker/docker/bundles/1.14.0-dev/binary-client/docker rm -fv 7523d0ccb5a5\nExitCode: 1, Error: exit status 1\nStdout: \nStderr: Error response from daemon: removal of container 7523d0ccb5a5 is already in progress\n\n\nFailures:\nExitCode was 1 expected 0\nExpected no error\n"} ("\nCommand: /go/src/github.com/docker/docker/bundles/1.14.0-dev/binary-client/docker rm -fv 7523d0ccb5a5\nExitCode: 1, Error: exit status 1\nStdout: \nStderr: Error response from daemon: removal of container 7523d0ccb5a5 is already in progress\n\n\nFailures:\nExitCode was 1 expected 0\nExpected no error\n")
15:35:15 
15:35:15 
15:35:15 ----------------------------------------------------------------------
15:35:15 PANIC: docker_cli_run_test.go:4401: DockerSuite.TestRunRmAndWait
15:35:15 
15:35:15 ... Panic: Fixture has panicked (see related PANIC)
15:35:15 
15:35:15 ----------------------------------------------------------------------
15:35:15 MISS: docker_cli_run_test.go:1224: DockerSuite.TestRunRootWorkdir
11:59:50 
11:59:50 ----------------------------------------------------------------------
11:59:50 FAIL: check_test.go:47: DockerSuite.TearDownTest
11:59:50 
11:59:50 check_test.go:49:
11:59:50     deleteAllContainers(c)
11:59:50 docker_utils.go:207:
11:59:50     c.Assert(err, checker.IsNil)
11:59:50 ... value *errors.errorString = &errors.errorString{s:"\nCommand: /go/src/github.com/docker/docker/bundles/1.14.0-dev/dynbinary-client/docker rm -fv 71a7baf05671\nExitCode: 1, Error: exit status 1\nStdout: \nStderr: Error response from daemon: removal of container 71a7baf05671 is already in progress\n\n\nFailures:\nExitCode was 1 expected 0\nExpected no error\n"} ("\nCommand: /go/src/github.com/docker/docker/bundles/1.14.0-dev/dynbinary-client/docker rm -fv 71a7baf05671\nExitCode: 1, Error: exit status 1\nStdout: \nStderr: Error response from daemon: removal of container 71a7baf05671 is already in progress\n\n\nFailures:\nExitCode was 1 expected 0\nExpected no error\n")
11:59:50 
11:59:50 
11:59:50 ----------------------------------------------------------------------
11:59:50 PANIC: docker_cli_restart_test.go:277: DockerSuite.TestRestartAutoRemoveContainer
11:59:50 
11:59:50 ... Panic: Fixture has panicked (see related PANIC)
11:59:50 
11:59:50 ----------------------------------------------------------------------
11:59:50 MISS: docker_cli_restart_test.go:147: DockerSuite.TestRestartContainerSuccess

cc @vdemeester

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions