Parser in docker 1.13 breaks backwards compatibility for comments in middle of RUN statement #29005
Description
Description
Previously (Docker 1.6+) one could document long RUN lines with comments interspersed. #24725 broke this.
FROM alpine
RUN echo \
# comment
hiSteps to reproduce the issue:
- build the above Dockerfile on 1.13-rc2
Describe the results you received:
Error response from daemon: Unknown instruction: HI
Describe the results you expected:
Docker build the above Dockerfile on 1.6 through 1.12 (thanks @tianon for testing all of them)
Successfully built xxx
Additional information you deem important (e.g. issue happens only occasionally):
Quick list of some official-images broken by this change:
- arangodb:2.5.5 from June 2015
- and all though arangodb:3.1.2
- bash
- cassandra
- elasticsearch
- golang:windowsservercore and nanoserver
- httpd
- irssi
- julia
- kibana
- logstash
- mariadb
- mongo:windowsservercore
- mysql:5.5
Output of docker version:
(working version)
Client:
Version: 1.12.3
API version: 1.24
Go version: go1.7.3
Git commit: 6b644ec
Built:
OS/Arch: linux/amd64
Server:
Version: 1.12.3
API version: 1.24
Go version: go1.7.3
Git commit: 6b644ec
Built:
OS/Arch: linux/amd64Output of docker info:
(working version)
Containers: 6
Running: 4
Paused: 0
Stopped: 2
Images: 5715
Server Version: 1.12.3
Storage Driver: overlay
Backing Filesystem: extfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: null overlay bridge host
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.8.8-gentoo
Operating System: Gentoo/Linux
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 30.87 GiB
Name: isengard
ID: UOCM:3F65:5FZC:6H5L:W3HY:34G4:A5XZ:SUOV:S2D4:XQTO:4KGA:6XSE
Docker Root Dir: /mnt/spare/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Insecure Registries:
127.0.0.0/8