-
Notifications
You must be signed in to change notification settings - Fork 18.9k
Closed
Labels
area/apiAPIAPIkind/questionpriority/P0Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed.Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed.
Milestone
Description
The current implementation of update(#15078), and thus the endpoint /containers/(id)/update, is using HostConfig struct although it's only updating Resources.
This raises few concerns :
- We decided that
updateshould only update stuff that are inResourcesstruct, but it's possible to send a completeHostConfigstruct which could lead to confusion — like why is some fields not taken care of, etc…. - If a complete
HostConfigstruct is passed, it will completely and silently ignore all attributes exceptResources. It should at least put a warning.
I think we should reduce what we send and change the API /containers/(id)/update to just take Resoures struct instead of HostConfig — it would make it clear that only stuff in this struct are supported (and it's simpler to implement than doing some diff or something and warn that something that is not in Resources has been wrongly set).
/cc @hqhq @tiborvass @thaJeztah @runcom @duglin @unclejack @icecrime @calavera
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/apiAPIAPIkind/questionpriority/P0Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed.Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed.