daemon: fix double-unlock in health check probe

corhere · corhere · commit 786c9adaa2af · 2023-06-22T17:48:21.000-04:00
Signed-off-by: Cory Snider &lt;csnider@mirantis.com&gt;
diff --git a/daemon/health.go b/daemon/health.go
@@ -160,7 +160,6 @@ func (p *cmdProbe) run(ctx context.Context, d *Daemon, cntr *container.Container
 		info.Lock()
 		defer info.Unlock()
 		if info.ExitCode == nil {
-			info.Unlock()
 			return 0, fmt.Errorf("healthcheck for container %s has no exit code", cntr.ID)
 		}
 		return *info.ExitCode, nil

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,6 @@ func (p cmdProbe) run(ctx context.Context, d Daemon, cntr *container.Container`
`160`	`160`	`info.Lock()`
`161`	`161`	`defer info.Unlock()`
`162`	`162`	`if info.ExitCode == nil {`
`163`		`- info.Unlock()`
`164`	`163`	`return 0, fmt.Errorf("healthcheck for container %s has no exit code", cntr.ID)`
`165`	`164`	`}`
`166`	`165`	`return *info.ExitCode, nil`