api: POST /commit: remove version-gate for "pause" (api < v1.16)

thaJeztah · thaJeztah · commit 1b1147e46b73 · 2024-02-06T18:42:27.000+01:00
The "pause" flag was added in API v1.13 (Docker Engine v1.1.0), and is enabled by default (see 17d870b). API v1.23 and older are deprecated, so we can remove the version-gate. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
diff --git a/api/server/router/container/container_routes.go b/api/server/router/container/container_routes.go
@@ -39,13 +39,6 @@ func (s *containerRouter) postCommit(ctx context.Context, w http.ResponseWriter,
 		return err
 	}
 
-	// TODO: remove pause arg, and always pause in backend
-	pause := httputils.BoolValue(r, "pause")
-	version := httputils.VersionFromContext(ctx)
-	if r.FormValue("pause") == "" && versions.GreaterThanOrEqualTo(version, "1.13") {
-		pause = true
-	}
-
 	config, _, _, err := s.decoder.DecodeConfig(r.Body)
 	if err != nil && !errors.Is(err, io.EOF) { // Do not fail if body is empty.
 		return err
@@ -57,7 +50,7 @@ func (s *containerRouter) postCommit(ctx context.Context, w http.ResponseWriter,
 	}
 
 	imgID, err := s.backend.CreateImageFromContainer(ctx, r.Form.Get("container"), &backend.CreateImageConfig{
-		Pause:   pause,
+		Pause:   httputils.BoolValueOrDefault(r, "pause", true), // TODO(dnephin): remove pause arg, and always pause in backend
 		Tag:     ref,
 		Author:  r.Form.Get("author"),
 		Comment: r.Form.Get("comment"),
