Skip to content

[19.03 backport] log error instead if disabling IPv6 router advertisement failed#2567

Merged
tiborvass merged 1 commit intomoby:bump_19.03from
thaJeztah:19.03_backport_no_error
Jun 17, 2020
Merged

[19.03 backport] log error instead if disabling IPv6 router advertisement failed#2567
tiborvass merged 1 commit intomoby:bump_19.03from
thaJeztah:19.03_backport_no_error

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

backport of #2563 for 19.03
addresses docker/for-linux#1033

Previously, failing to disable IPv6 router advertisement prevented the daemon to
start.

An issue was reported by a user that started docker using systemd-nspawn "machine",
which produced an error;

failed to start daemon: Error initializing network controller:
Error creating default "bridge" network: libnetwork:
Unable to disable IPv6 router advertisement:
open /proc/sys/net/ipv6/conf/docker0/accept_ra: read-only file system

This patch changes the error to a log-message instead.

Previously, failing to disable IPv6 router advertisement prevented the daemon to
start.

An issue was reported by a user that started docker using `systemd-nspawn "machine"`,
which produced an error;

    failed to start daemon: Error initializing network controller:
    Error creating default "bridge" network: libnetwork:
    Unable to disable IPv6 router advertisement:
    open /proc/sys/net/ipv6/conf/docker0/accept_ra: read-only file system

This patch changes the error to a log-message instead.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 8dd33dc)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review June 12, 2020 18:12
@arkodg arkodg requested a review from cpuguy83 June 12, 2020 18:13
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants