[19.03 backport] Fix 'failed to get network during CreateEndpoint'#2565
Merged
selansen merged 1 commit intomoby:bump_19.03from Jun 10, 2020
s0j:s0j_bump_19.03_fix-network-not-found
Merged
[19.03 backport] Fix 'failed to get network during CreateEndpoint'#2565selansen merged 1 commit intomoby:bump_19.03from s0j:s0j_bump_19.03_fix-network-not-found
selansen merged 1 commit intomoby:bump_19.03from
s0j:s0j_bump_19.03_fix-network-not-found
Conversation
Fix 'failed to get network during CreateEndpoint' during container starting. Change the error type to `libnetwork.ErrNoSuchNetwork`, so `Start()` in `daemon/cluster/executor/container/controller.go` will recreate the network. Signed-off-by: Xinfeng Liu <xinfeng.liu@gmail.com> (cherry picked from commit 1df7f7e) Signed-off-by: Shane Jarych <sjarych@mirantis.com>
SamWhited
approved these changes
Jun 10, 2020
Contributor
SamWhited
left a comment
There was a problem hiding this comment.
LGTM. Minor nit that the error should either be handled (ie logged) or returned, but not both, but it's a backport so probably not something to be fixed in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #2554 for the 19.03 branch
Fix 'failed to get network during CreateEndpoint' during container starting.
Change the error type to
libnetwork.ErrNoSuchNetwork, soStart()indaemon/cluster/executor/container/controller.gowill recreate the network.Signed-off-by: Xinfeng Liu xinfeng.liu@gmail.com
(cherry picked from commit 1df7f7e)
Signed-off-by: Shane Jarych sjarych@mirantis.com