Skip to content

Cleanup host discovery#2509

Closed
aiordache wants to merge 1 commit intomoby:masterfrom
aiordache:libnetwork_rm_node_discovery
Closed

Cleanup host discovery#2509
aiordache wants to merge 1 commit intomoby:masterfrom
aiordache:libnetwork_rm_node_discovery

Conversation

@aiordache
Copy link
Copy Markdown

@aiordache aiordache commented Feb 19, 2020 •
edited
Loading

Signed-off-by: Anca Iordache anca.iordache@docker.com
relates to moby/moby#40383

eunomie
eunomie reviewed Feb 20, 2020
View reviewed changes
Copy link
Copy Markdown

@eunomie eunomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more occurrence of github.com/docker/docker/pkg/discovery needs to be removed

$ ack pkg/discovery vendor/github.com/docker/libnetwork/
vendor/github.com/docker/libnetwork/config/config.go
8:      "github.com/docker/docker/pkg/discovery"

@eunomie eunomie mentioned this pull request Feb 20, 2020
Closed
@chris-crone chris-crone requested a review from arkodg February 21, 2020 09:14
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Feb 21, 2020

will review this once the moby counterpart PR is green since most swarm tests are present there

eunomie
eunomie reviewed Feb 26, 2020
View reviewed changes
@aiordache aiordache force-pushed the libnetwork_rm_node_discovery branch 2 times, most recently from d5b7275 to d530ef9 Compare March 3, 2020 10:08
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Mar 3, 2020

Thanks for looking into this; so I'd be interested to see if we still require libkv (and if we could get rid of the dependencies for external k/v stores). I see boltdb is also used through the k/v store (and think we still use that, but not sure 😓). Here's a quick attempt to see what happens if we remove some of the code related to external k/v drivers; #2521

@thaJeztah thaJeztah mentioned this pull request Mar 4, 2020
Closed
@aiordache aiordache force-pushed the libnetwork_rm_node_discovery branch from d34d1a3 to 53d79e6 Compare March 10, 2020 09:39
remove external DS-based host discovery
77c3796 
Signed-off-by: Anca Iordache <anca.iordache@docker.com>
@aiordache aiordache force-pushed the libnetwork_rm_node_discovery branch from e116439 to 77c3796 Compare March 10, 2020 10:46
@thaJeztah thaJeztah mentioned this pull request Apr 2, 2021
Closed
@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Jun 18, 2021

Note we have migrated this codebase over to github.com/moby/moby/libnetwork.
We are not accepting PR's on this repo anymore except for backports to be included in moby 20.10

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jan 6, 2022

closing this one; this has been merged in moby through moby/moby#42247

@thaJeztah thaJeztah closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

@chris-crone chris-crone Awaiting requested review from chris-crone

@arkodg arkodg Awaiting requested review from arkodg

1 more reviewer

@eunomie eunomie eunomie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aiordache @arkodg @thaJeztah @cpuguy83 @eunomie