Skip to content

validate network and endpoint name more strictly#1510

Merged
mrjana merged 1 commit intomoby:masterfrom
allencloud:validate-network-and-endpoint-name-strictly
Nov 2, 2016
Merged

validate network and endpoint name more strictly#1510
mrjana merged 1 commit intomoby:masterfrom
allencloud:validate-network-and-endpoint-name-strictly

Conversation

@allencloud
Copy link
Copy Markdown
Contributor

@allencloud allencloud commented Oct 17, 2016

fixes moby/moby#27449

I think currently docker network name validation is not so strict.
This PR tries to make it more strictly like container or volume name validation.

Signed-off-by: allencloud allen.sun@daocloud.io

@allencloud allencloud force-pushed the validate-network-and-endpoint-name-strictly branch 6 times, most recently from daceab4 to d43f9fd Compare October 17, 2016 16:53
@allencloud
validate network and endpoint name more strictly
1807951 
Signed-off-by: allencloud <allen.sun@daocloud.io>
@allencloud allencloud force-pushed the validate-network-and-endpoint-name-strictly branch from d43f9fd to 1807951 Compare October 18, 2016 03:02
@allencloud
Copy link
Copy Markdown
Contributor Author

allencloud commented Oct 25, 2016

Any update?

@aboch
Copy link
Copy Markdown
Contributor

aboch commented Oct 25, 2016

This will only affect creation of new networks.
If a network with now unsupported chars in its name existed (in the store), it should not get affected by this change. User will still be able to use it.
Regarding to network endpoints, their name construction is not exposed to users, it is done inside docker and already conform to the added regex.

LGTM

@allencloud
Copy link
Copy Markdown
Contributor Author

allencloud commented Nov 1, 2016

ping @mrjana @sanimej PTAL
Thanks a lot.

@mrjana
Copy link
Copy Markdown
Contributor

mrjana commented Nov 2, 2016

LGTM

@mrjana mrjana merged commit a54d631 into moby:master Nov 2, 2016
@thaJeztah thaJeztah mentioned this pull request Nov 2, 2016
Closed
@allencloud allencloud deleted the validate-network-and-endpoint-name-strictly branch November 9, 2016 02:07
@lowenna
Copy link
Copy Markdown
Member

lowenna commented Nov 16, 2016

Why should a network name not allow a space?

@lowenna
Copy link
Copy Markdown
Member

lowenna commented Nov 16, 2016

To add to ^^ This unfortunately breaks a lot of internal automation we have where machines are prepped with network names including spaces. There's no reason I can think of to be that restrictive.

@aboch aboch mentioned this pull request Nov 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status/2-needs-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docker network name validation is not so strict

5 participants

@allencloud @aboch @mrjana @lowenna @GordonTheTurtle