Add missing locks around broadcasts#996
Merged
thaJeztah merged 1 commit intomoby:masterfrom May 11, 2019
Merged
Conversation
tonistiigi
approved these changes
May 10, 2019
thaJeztah
requested changes
May 10, 2019
Member
thaJeztah
left a comment
There was a problem hiding this comment.
@msg555 could you perhaps update your sign-off to use your actual name (instead of msg)?
Signed-off-by: msg <msg@clinc.com>
You can configure your name in your git configuration (so it would use it automatically if you use commit -s next time)
Signed-off-by: Mark Gordon <msg555@gmail.com>
Contributor
Author
|
Updated sign off, my mistake |
thaJeztah
approved these changes
May 11, 2019
Member
thaJeztah
left a comment
There was a problem hiding this comment.
no worries! Thanks for fixing the sign off
LGTM
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid race conditions related to broadcasting prior to the intended thread having invoked Wait already you need to lock the wrapping mutex before broadcasting.
https://pastebin.com/tNitJ5L2 demonstrates why unlocked broadcasts are problematic.