http: add better support for misconfigured servers#835
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Mar 1, 2019
Merged
http: add better support for misconfigured servers#835AkihiroSuda merged 1 commit intomoby:masterfrom
AkihiroSuda merged 1 commit intomoby:masterfrom
Conversation
4506429 to
9ac8b00
Compare
AkihiroSuda
reviewed
Feb 28, 2019
source/http/httpsource.go
Outdated
| } | ||
| } | ||
|
|
||
| // handle misconfigured servers |
Member
There was a problem hiding this comment.
could you add more description about misconfiguration?
AkihiroSuda
approved these changes
Feb 28, 2019
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
9ac8b00 to
ab5d494
Compare
AkihiroSuda
approved these changes
Mar 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing with github source URLs I found that the http source implementation didn't cooperate very well. From tracing the requests it seems to be a server fault but made some changes to handle misbehaving servers better.
Instead of sending multipe if-none-match headers (that should be supported) now join them into a single value.
Do an extra HEAD request for detecting the unchanged etag, in case server does not actually handle the in-none-match header.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com