client: use inactivity timeout for status stream shutdown#6396
Merged
tonistiigi merged 1 commit intomoby:masterfrom Dec 5, 2025
Merged
client: use inactivity timeout for status stream shutdown#6396tonistiigi merged 1 commit intomoby:masterfrom
tonistiigi merged 1 commit intomoby:masterfrom
Conversation
Instead of using a fixed 3-second timeout after solve completion, use an inactivity-based timeout that waits 5 seconds since the last received status message. This prevents premature stream closure when status messages are still being delivered through slow connections (e.g., proxied environments). Also ignore context.Canceled errors in the status goroutine to avoid failing builds when the inactivity timeout triggers - the build itself succeeded, we just may have missed some final status messages. Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
b61b2ae to
961bf27
Compare
tonistiigi
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using a fixed 3-second timeout after solve completion, use an inactivity-based timeout that waits 5 seconds since the last received status message. This prevents premature stream closure when status messages are still being delivered through slow connections (e.g., proxied environments).
Also ignore context.Canceled errors in the status goroutine to avoid failing builds when the inactivity timeout triggers - the build itself succeeded, we just may have missed some final status messages.