buildkitd: handle device insecure entitlement#6080
Merged
crazy-max merged 1 commit intomoby:masterfrom Jul 15, 2025
Merged
Conversation
This was referenced Jul 11, 2025
Member
Author
|
I was looking at the integration tests and I think we need a sandbox mode for device similar to netModeHost and secModeInsecure. Let me know if you want that here or as follow-up. |
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
207718c to
bc0c857
Compare
AkihiroSuda
reviewed
Jul 14, 2025
| cfg.Entitlements = append(cfg.Entitlements, e) | ||
| case "network.host": | ||
| cfg.Entitlements = append(cfg.Entitlements, e) | ||
| case "device": |
Member
There was a problem hiding this comment.
So far an entitlement was supposed to be two words separate by a comma
AkihiroSuda
approved these changes
Jul 14, 2025
tonistiigi
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up docker/buildx#3295 (comment)