Merged
Conversation
thaJeztah
reviewed
Feb 19, 2024
thaJeztah
approved these changes
Feb 19, 2024
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM (but perhaps a note would be useful, or would it be clear for readers?)
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
bd350f5 to
fc7cd81
Compare
This was referenced Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to https://github.com/moby/buildkit/actions/runs/7957965041/job/21723057849#step:9:41
Since https://github.com/codecov/codecov-action/releases/tag/v4.0.0, the token is now required for public repos when the action runs on a branch/tag of this repo. But contributors creating PRs from their forks to the upstream repo will be able to get coverage information from Codecov. I guess this is because they don't have access to the secret. This is related to https://about.codecov.io/blog/january-product-update-updating-the-codecov-ci-uploaders-to-the-codecov-cli/
As discussed with @thaJeztah, an org-wide secret has been created so it can be used across repos of this org to fix this issue.