[0.12 backport] util/resolver: Fix insecure mirrors#4297
Merged
tonistiigi merged 1 commit intomoby:v0.12from Oct 2, 2023
Merged
[0.12 backport] util/resolver: Fix insecure mirrors#4297tonistiigi merged 1 commit intomoby:v0.12from
tonistiigi merged 1 commit intomoby:v0.12from
Conversation
Mirrors in `RegistryConfig.Mirrors` can be specified using a full URL (schema, trailing slashes) but registries in the input map are keyed by their hostname. Previous code used the mirror URL as key which resulted in an empty `RegistryConfig` being passed to the `fillInsecureOpts` function and didn't set the insecure options. Use Host part of the parsed registry as a key instead. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit ec65557) Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
tonistiigi
approved these changes
Oct 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors in
RegistryConfig.Mirrorscan be specified using a full URL (schema, trailing slashes) but registries in the input map are keyed by their hostname.Previous code used the mirror URL as key which resulted in an empty
RegistryConfigbeing passed to thefillInsecureOptsfunction and didn't set the insecure options.Use Host part of the parsed registry as a key instead.
(cherry picked from commit ec65557)