Dockerfile: Bump up containerd-related deps (containerd v1.6.20, nerdctl v1.3.0, stargz-snapshotter v0.14.3, runc v1.1.6)#3789
Conversation
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Dockerfile
Outdated
| @@ -3,12 +3,12 @@ | |||
| ARG RUNC_VERSION=v1.1.5 | |||
There was a problem hiding this comment.
thaJeztah
left a comment
There was a problem hiding this comment.
overall updating LGTM, but left a comment / suggestion
| # syntax=docker/dockerfile-upstream:master | ||
|
|
||
| ARG RUNC_VERSION=v1.1.5 | ||
| ARG RUNC_VERSION=v1.1.6 |
There was a problem hiding this comment.
Should we have the Dockerfile changes separate from the vendor changes? They should (probably, and at least for runc) have no direct relation with each-other
The Dockerfile is the binary version to test against, and the vendor is "what dependency version" to use to build BuildKit itself.
Having them separate (separate PRs?) also allows verifying that the binary updates work separate from updating buildkit itself (and could help catching regressions / backward-compatibility breaking changes) in any of these)
There was a problem hiding this comment.
Thank you for the comment. Separated go.mod changes to other PRs
- stargz-snapshotter: go.mod: Bump up stargz-snapshotter to v0.14.3 #3792
- runc: go.mod: bump up runc to v1.1.6 #3793
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
go.mod changes are separated to other PRs