Skip to content

testutil: pin busybox and alpine used in releases#3469

Merged
tonistiigi merged 1 commit intomoby:masterfrom
tonistiigi:pin-test-images
Jan 6, 2023
Merged

testutil: pin busybox and alpine used in releases#3469
tonistiigi merged 1 commit intomoby:masterfrom
tonistiigi:pin-test-images

Conversation

@tonistiigi
Copy link
Copy Markdown
Member

@tonistiigi tonistiigi commented Jan 6, 2023

replaces #3464

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@tonistiigi tonistiigi mentioned this pull request Jan 6, 2023
Merged
@tonistiigi
testutil: pin busybox and alpine used in releases
2f48f16 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi merged commit b55dab7 into moby:master Jan 6, 2023
@tonistiigi tonistiigi mentioned this pull request Jan 6, 2023
Closed
This was referenced Jan 7, 2023
Merged
Merged
@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Jan 8, 2023

Still failing https://github.com/moby/buildkit/actions/runs/3858054800/jobs/6576171616

#5 [build 1/3] FROM docker.io/library/busybox@sha256:7b3ccabffc97de872a30dfd234fd972a66d247c8cfc69b0550f276481852627c
#5 resolve docker.io/library/busybox@sha256:7b3ccabffc97de872a30dfd234fd972a66d247c8cfc69b0550f276481852627c done
#5 sha256:205dae5015e78dd8c4d302e3db4eb31576fac715b46d099fe09680ba28093a7a 2.59MB / 2.59MB 0.1s done
#5 extracting sha256:205dae5015e78dd8c4d302e3db4eb31576fac715b46d099fe09680ba28093a7a 0.1s done
#5 DONE 0.2s

#6 [build 2/3] RUN cat /dev/urandom | head -c 100 | sha256sum > unique_first
#6 0.479 Illegal instruction (core dumped)
time="2023-01-06T19:56:23Z" level=error msg="/moby.buildkit.v1.Control/Solve returned error: rpc error: code = Unknown desc = process \"/bin/sh -c cat /dev/urandom | head -c 100 | sha256sum > unique_first\" did not complete successfully: exit code: 132"
#6 ERROR: process "/bin/sh -c cat /dev/urandom | head -c 100 | sha256sum > unique_first" did not complete successfully: exit code: 132
------
 > [build 2/3] RUN cat /dev/urandom | head -c 100 | sha256sum > unique_first:
#6 0.479 Illegal instruction (core dumped)
------
Dockerfile:2
--------------------
   1 |     FROM busybox AS build
   2 | >>> RUN cat /dev/urandom | head -c 100 | sha256sum > unique_first
   3 |     RUN cat /dev/urandom | head -c 100 | sha256sum > unique_second
   4 |     
--------------------
error: failed to solve: process "/bin/sh -c cat /dev/urandom | head -c 100 | sha256sum > unique_first" did not complete successfully: exit code: 132

AkihiroSuda
AkihiroSuda reviewed Jan 8, 2023
View reviewed changes
util/testutil/integration/pins.go
"amd64": "sha256:c0d488a800e4127c334ad20d61d7bc21b4097540327217dfab52262adc02380c",
"arm64v8": "sha256:af06af3514c44a964d3b905b498cf6493db8f1cde7c10e078213a89c87308ba0",
"library": "sha256:8914eb54f968791faf6a8638949e480fef81e697984fba772b3976835194c6d4",
},
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Jan 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use the digest of the multi-platform index?

Copy link
Copy Markdown
Member Author

@tonistiigi tonistiigi Jan 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc this was optimization in amd64/arm64 to avoid mirroring the unneeded architectures. Other arch use library ns with multi-platform.

@AkihiroSuda AkihiroSuda mentioned this pull request Jan 8, 2023
Merged
AkihiroSuda
AkihiroSuda reviewed Jan 8, 2023
View reviewed changes
util/testutil/integration/pins.go
package integration

var pins = map[string]map[string]string{
// busybox is pinned to 1.35. Newer produces has "illegal instruction" panic on some of Github infra on sha256sum
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Jan 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this issue tracked somewhere?

Can't find a ticket in https://github.com/docker-library/busybox/issues and https://bugs.busybox.net/buglist.cgi?chfield=%5BBug%20creation%5D&chfieldfrom=30 .

Seems related to mirror/busybox@6472ac9 though.

Copy link
Copy Markdown
Member Author

@tonistiigi tonistiigi Jan 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reported to busybox yet. If you do, you can post this debug: https://github.com/tonistiigi/gh-busybox-sigill-debug/actions/runs/3858482123

Good CPUs: 8370C, E5-2673
Bad CPUs: 8171M, 8272CL

Copy link
Copy Markdown
Member Author

@tonistiigi tonistiigi Jan 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://bugs.busybox.net/show_bug.cgi?id=15236

@crazy-max crazy-max mentioned this pull request Feb 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

@crazy-max crazy-max crazy-max approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tonistiigi @AkihiroSuda @crazy-max