go.mod: github.com/containerd/containerd v1.7.0-beta.3#3395
go.mod: github.com/containerd/containerd v1.7.0-beta.3#3395tonistiigi merged 1 commit intomoby:masterfrom
Conversation
| return instrumentationScope(s.is) | ||
| } | ||
|
|
||
| // Deprecated: use InstrumentationScope. |
There was a problem hiding this comment.
c6e7f9f to
a980c0a
Compare
a980c0a to
14a2084
Compare
14a2084 to
fe3a0c6
Compare
fe3a0c6 to
4126f55
Compare
57b3c58 to
f7e7550
Compare
|
@tonistiigi Can we remove the |
f7e7550 to
5d662ca
Compare
|
Rebased |
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
5d662ca to
d63a2bc
Compare
|
Updated to beta.3 |
| "go.opentelemetry.io/otel/sdk/instrumentation" | ||
| ) | ||
|
|
||
| func instrumentationLibrary(il *commonpb.InstrumentationLibrary) instrumentation.Library { |
There was a problem hiding this comment.
Looks like this library has been updated a lot in the upstream. Please follow-up with full update so we get all the changes.
There was a problem hiding this comment.
There was a problem hiding this comment.
?
You meand you want to update otel again before addressing this?
Atm buildkit has copy of otel library https://github.com/moby/buildkit/tree/master/util/tracing/transform . We can't link upstream because that package was internal. Unless there is now a better way to do this we should keep this package up to date when we update otel in vendor.
There was a problem hiding this comment.
Sorry, didn't get what you meant by "full update", but looks like you meant copying https://github.com/open-telemetry/opentelemetry-go/tree/main/exporters/otlp/otlptrace/internal/tracetransform to https://github.com/moby/buildkit/tree/master/util/tracing/transform
Depended by: