ci: move frontend integration tests and build to a dedicated workflow#3237
Merged
crazy-max merged 6 commits intomoby:masterfrom Feb 16, 2023
Merged
ci: move frontend integration tests and build to a dedicated workflow#3237crazy-max merged 6 commits intomoby:masterfrom
crazy-max merged 6 commits intomoby:masterfrom
Conversation
dcb438a to
0c4bdc6
Compare
5ce2eae to
ee7d15a
Compare
Closed
ee7d15a to
35e595c
Compare
a6c441c to
1998bad
Compare
crazy-max
commented
Jan 31, 2023
1998bad to
a867b81
Compare
a867b81 to
295a04b
Compare
jedevc
reviewed
Feb 15, 2023
Member
jedevc
left a comment
There was a problem hiding this comment.
I think this seems roughly good to me, though I haven't taken a deep look yet.
I think we might want to rename build.yml though, maybe to buildkitd.yml, since it now just build+tests related to that, since frontend.yml does build+tests related to the dockerfile frontend.
c64783a to
3a458ac
Compare
Split dockerfile frontend integration tests and build in a dedicated workflow so we have a clear separation of concerns and also avoid building the frontend when a BuildKit tag is pushed and vice versa with a dockerfile tag. Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
3a458ac to
97d3b59
Compare
jedevc
reviewed
Feb 16, 2023
| run: | | ||
| go mod download | ||
| - | ||
| name: Test |
Member
There was a problem hiding this comment.
There's a few test jobs that don't use the reusable workflow - like this one. Is there a reason we can't use it in every case?
Member
Author
There was a problem hiding this comment.
Yeah unfortunately for test-os we can't pass the os (e.g. windows-2022) as an input to the reusable workflow. That's why I just moved this one in a dedicated wokrflow. I think GitHub is working on a fix for this.
jedevc
approved these changes
Feb 16, 2023
This was referenced Feb 16, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split dockerfile frontend integration tests and build in a dedicated workflow so we have a clear separation of concerns and also avoid building the frontend when a BuildKit tag is pushed and vice versa with a dockerfile tag.
Also create a reusable workflow for our tests and move test-os job to a dedicated workflow.
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com