Move config parsing to a dedicated pkg#2361
Conversation
tonistiigi
left a comment
There was a problem hiding this comment.
A package that contains the buildkit specific configuration structures should not be in util. cmd/buildkitd seems like a correct place. I'm fine with separating packages though. Would be better if toml parsing and config definition is not in same package but with the current split I'd at least hope that we can leave the containerd/userns dependency out of here.
feb42c8 to
3b64d69
Compare
Ok I thought it was fine like
Moved to |
|
|
3b64d69 to
681b8e6
Compare
be5c6d5 to
8b22da2
Compare
|
@tonistiigi Ok now toml parsing is in its own pkg and moved back config to |
c2f20c4 to
437da63
Compare
|
@tonistiigi Moved to |
|
437da63 to
9cd28ae
Compare
2ab4bc6 to
da188c1
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
da188c1 to
3fd4338
Compare
tonistiigi
left a comment
There was a problem hiding this comment.
It's generally better to have a pkg that only defines the config structures and no dependency on toml parsing but we can fix that in follow-up if it comes up.
We can't use the buildkitd config from
cmdso move it toutil. The idea will be to be able to load the toml configuration from buildx in a follow-up in order to inject the root ca and user tls certs when we create a builder with thedocker-containerdriver.Signed-off-by: CrazyMax crazy-max@users.noreply.github.com