Skip to content

dockerfile: fix git version detection#2208

Merged
AkihiroSuda merged 1 commit intomoby:masterfrom
tonistiigi:dockerfile-version
Jun 29, 2021
Merged

dockerfile: fix git version detection#2208
AkihiroSuda merged 1 commit intomoby:masterfrom
tonistiigi:dockerfile-version

Conversation

@tonistiigi
Copy link
Copy Markdown
Member

fix #2206

Looks like this broke in #2037 with migration from debian to alpine.

@coryb

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

ARG CHANNEL
# TODO: PKG should be inferred from go modules
RUN --mount=target=. \
set -e; \
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use && ?

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi force-pushed the dockerfile-version branch from f3802df to dc86c52 Compare June 29, 2021 05:06
@AkihiroSuda AkihiroSuda merged commit bb6f11c into moby:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dockerfile: git version check fails in ci

2 participants