remotecache: make sure local writer commits close grpc stream#2025
Closed
tonistiigi wants to merge 1 commit intomoby:masterfrom
Closed
remotecache: make sure local writer commits close grpc stream#2025tonistiigi wants to merge 1 commit intomoby:masterfrom
tonistiigi wants to merge 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
AkihiroSuda
reviewed
Mar 16, 2021
| rw.offset = resp.Offset | ||
| return nil | ||
|
|
||
| return rw.Close() |
Member
There was a problem hiding this comment.
This should be also called in defer
Member
There was a problem hiding this comment.
(On second thought, defer close might not be needed)
Member
Author
There was a problem hiding this comment.
I think commit should be "finalized" even if an error is returned
Member
Author
|
Upstream fix has been vendored in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AkihiroSuda I randomly get
on client side while exporting to the local cache. iiuc this is because the exporter doesn't cleanly close the grpc writer and so the loop that reads from it in the client side might close with cancellation error after build has completed and
session.Closehas been called.As this is in vendored code I'm not sure how it is supposed to work or if this change is really missing in upstream.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com