fix tests after busybox update#1681
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Sep 13, 2020
Merged
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
8666941 to
b18c08c
Compare
AkihiroSuda
approved these changes
Sep 13, 2020
Member
|
Yep, this was a result of buildroot/buildroot@0d887cc and seems pretty intentional; I'll be really surprised if they revert it. |
This was referenced Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is broken and the issue seems to be not a buildkit change but a change in busybox image used in test.
We should probably also pin to a specific version to avoid this. But corrected the tests atm.
@tianon I assume this change was intentional and we don't expect a rollback.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com