Merged
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
fuweid
reviewed
Aug 2, 2020
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Was disabled with http2 but shouldn’t have been. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
8b37573 to
22061b1
Compare
Collaborator
|
Changes LGTM but should there additionally be a similar fix to |
Member
Author
|
@sipsma I think it is ok atm. The difference is that |
AkihiroSuda
approved these changes
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should significantly improve performance for registry communication. Still a lot of things to improve but at least all regressions should be gone now. For further changes, I'd need to make more auth helper functions public in containerd to avoid copy-paste.
@sipsma @fuweid