[v0.6 backport] contenthash: ignore system and security xattrs in calculation#1517
Merged
tonistiigi merged 2 commits intomoby:docker-19.03from Jul 16, 2020
Merged
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 81e7113) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
@tonistiigi @AkihiroSuda ptal |
AkihiroSuda
approved these changes
Jun 4, 2020
Member
|
if I remember correctly it was concluded that this was wrong and |
Member
Author
|
good point; I'd have to check; do you know if that was addressed on master? |
Member
|
@thaJeztah I don't think so. |
|
@thaJeztah Do you know if anyone is working on the changes that @tonistiigi mentioned? Clamoring for this change at this point. I'd make them myself and PR but I'm sure it'd be quicker if a member of the project could make the changes and pull them in. |
Member
|
@mtanatwine #1526 |
|
Looks like #1526 was merged, so can that get merged into this backport so we can get it in v19? |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit b0d3737) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
Cherry-picked #1526. PTAL |
tonistiigi
approved these changes
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport for the v0.6 / docker-19.03 branch