Merged
Conversation
Signed-off-by: Zach Badgett <zach.badgett@gmail.com>
Signed-off-by: Zach Badgett <zach.badgett@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
91cdf5c to
a60ecfa
Compare
AkihiroSuda
reviewed
Feb 25, 2020
|
|
||
| replace github.com/jaguilar/vt100 => github.com/tonistiigi/vt100 v0.0.0-20190402012908-ad4c4a574305 | ||
|
|
||
| replace github.com/containerd/containerd => github.com/containerd/containerd v1.3.1-0.20191014053712-acdcf13d5eaf |
Member
There was a problem hiding this comment.
github.com/containerd/containerd v1.4.0-0.20191014053712-acdcf13d5eaf in L13 should be like github.com/containerd/containerd v0.0.0?
Member
Author
There was a problem hiding this comment.
Is there a case that requires this. As long as replace has the "sanitized" version it seems to work for me.
Member
There was a problem hiding this comment.
Just for human understandability
Member
Author
There was a problem hiding this comment.
v1.4.0-0 might improve understandability as well, as it is "newer than 1.3"
AkihiroSuda
approved these changes
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
carry #1297