Skip to content

fileop: keep correct user for parent dir on userns#1342

Merged
tiborvass merged 1 commit intomoby:masterfrom
tonistiigi:userns-chown
Jan 30, 2020
Merged

fileop: keep correct user for parent dir on userns#1342
tiborvass merged 1 commit intomoby:masterfrom
tonistiigi:userns-chown

Conversation

@tonistiigi
Copy link
Copy Markdown
Member

@tonistiigi tonistiigi commented Jan 24, 2020

fix for moby/moby#40335

depends on tonistiigi/fsutil#70

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi marked this pull request as ready for review January 28, 2020 19:37
@tonistiigi
Copy link
Copy Markdown
Member Author

@TBBle I left the hcsshim dependency as v0.8.5 in this one like it was in old fsutil. It's a wrong version and doesn't match what containerd defines but wanted to avoid lot of unrelated changes in this PR.

@TBBle
Copy link
Copy Markdown
Collaborator

TBBle commented Jan 29, 2020

That makes sense. To make the desired version of hcsshim visible to Go modules, we also need to revendor containerd, and that appears to be blocked behind #1297.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants