solver: support no-cache for exec cache mounts#1092
Merged
tiborvass merged 2 commits intomoby:masterfrom Jul 30, 2019
Merged
Conversation
tiborvass
reviewed
Jul 26, 2019
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
cd3ad29 to
7b1bae7
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tiborvass
approved these changes
Jul 30, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes docker/buildx#109
No-cache doesn't really work in combination with cache mounts as it is solver level and caches instructions. But the behavior is non-obvious from the user perspective. So if no-cache is used in a run operation that uses cache mounts, all cache volumes with the matching id are released before the build even starts now.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com