Skip to content

Merge+Diff follow-ups #2548

@sipsma

Description

@sipsma

Tracking followups from comments on merge+diff here. Can instead break this into separate issues for each one if preferred.

Short-term followups:

Performance followups:

  • Deduplicate equivalent merges
  • Deduplicate equivalent diffs
  • Re-use submerges when possible, i.e. if Merge(a,b) already exists, use it to speed up creation of Merge(a,b,c)
  • Normalize merges to their simplest form, i.e. Merge(a,b,a) is logically equivalent to the simpler Merge(b,a)
  • Don't finalize input refs when they are created by llb.Local. Comment here.

Longer-term followups:

  • Cache diff metadata and use it to apply diffs instead of always running the double-walking or overlay differ every time. Comment here
  • Deduplicate code between diffApply and the containerd/continuity appliers+differs. Comment here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions