Skip to content

fix: missing 'state' in device info #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmegidish merged 1 commit into from
Dec 10, 2025
Merged

fix: missing 'state' in device info #135

gmegidish merged 1 commit into from
Dec 10, 2025

Conversation

@gmegidish
Copy link
Member

@gmegidish gmegidish commented Dec 10, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Device state information is now included in device information responses for Android, iOS, and Simulator devices.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025 •
edited
Loading

Walkthrough

The changes add the State field to DeviceInfo structs across three device implementations (Android, iOS, Simulator), with each populating it by calling the respective device's State() method.

Changes

Cohort / File(s) Summary
State field addition to DeviceInfo
devices/android.go, devices/ios.go, devices/simulator.go		 Added State field to DeviceInfo returned by Info() method, populated via respective State() method calls

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: missing state in device info' directly and clearly describes the main change across all three files—adding the missing State field to DeviceInfo returned by device Info() methods.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-missing-state-in-device-info
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 762dd2d and 5b58864.

📒 Files selected for processing (3)
  • devices/android.go (1 hunks)
  • devices/ios.go (1 hunks)
  • devices/simulator.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: lint
  • GitHub Check: Analyze (go)
🔇 Additional comments (3)
devices/android.go (1)

763-763: LGTM! State field correctly populated.

The State field is now properly included in the DeviceInfo, populated by calling d.State() which returns the device's current state ("online" or "offline"). This is consistent with the other DeviceInfo fields.

devices/ios.go (1)

632-632: LGTM! State field correctly populated.

The State field is properly added to DeviceInfo, populated via d.State() which returns "online" for real iOS devices. This is consistent with the implementation pattern across all device types.

devices/simulator.go (1)

692-692: LGTM! State field correctly populated.

The State field is properly included in the DeviceInfo, populated by calling s.State() which translates the simulator's internal state to "online" or "offline". This maintains consistency with the Android and iOS implementations.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit b852160 into main Dec 10, 2025
7 of 8 checks passed
@gmegidish gmegidish deleted the fix-missing-state-in-device-info branch December 14, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmegidish