Skip to content

feat: added --ignore-scripts to npm install #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmegidish merged 1 commit into from
Nov 29, 2025
Merged

feat: added --ignore-scripts to npm install #122

gmegidish merged 1 commit into from
Nov 29, 2025

Conversation

@gmegidish
Copy link
Member

@gmegidish gmegidish commented Nov 27, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Optimized CI/CD workflow efficiency by streamlining dependency installation across build and test processes.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 27, 2025 •
edited
Loading

Walkthrough

The GitHub Actions workflow is updated to add --ignore-scripts flag to npm install commands across multiple workflow steps. This prevents execution of npm lifecycle scripts during dependency installation, simplifying the build process without introducing new logic or altering control flow.

Changes

Cohort / File(s) Summary
Workflow dependency installation flag
.github/workflows/build.yml		 Added --ignore-scripts flag to npm install commands across iOS tests, server tests, Android test steps, Android emulator steps, and publish workflow steps to prevent execution of npm lifecycle scripts during dependency installation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify --ignore-scripts flag is applied consistently across all affected workflow steps
  • Confirm that skipping lifecycle scripts does not break any required setup or initialization for tests and builds

Poem

🐰 Scripts bundled tight, now we skip with might,
Through workflows swift, dependencies light,
No postinstall delays in our GitHub night,
Faster builds hopping, everything just right! ⚡

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding --ignore-scripts flag to npm install commands across workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-added-ignore-scripts-to-npm-install
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3bec98 and dec2b98.

📒 Files selected for processing (1)
  • .github/workflows/build.yml (5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: lint
🔇 Additional comments (4)
.github/workflows/build.yml (4)

223-223: Verify that npm lifecycle scripts are not critical for test execution.

The --ignore-scripts flag is a standard CI optimization that prevents postinstall and other lifecycle scripts from running during dependency installation.

Please confirm that the project does not have critical npm lifecycle scripts (e.g., postinstall hooks) required for the iOS test suite to function correctly. You can verify this by checking the scripts section in package.json or by test-running this workflow step locally.

247-247: Consistent optimization across test workflows.

The --ignore-scripts flag is applied consistently in the server test step, following the same pattern as other test workflows.

305-305: Consistent with other test environment changes.

The --ignore-scripts flag is correctly applied in the Android emulator setup step.

413-413: Appropriate for the publish workflow.

The --ignore-scripts flag in the publish step correctly prevents unnecessary script execution while preparing the npm package for release. This is a standard optimization for release workflows.

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit 82a9d31 into main Nov 29, 2025
15 checks passed
@gmegidish gmegidish deleted the feat-added-ignore-scripts-to-npm-install branch November 29, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmegidish