Skip to content

feat: removed -no-snapshot-load and added -no-window #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmegidish merged 1 commit into from
Nov 26, 2025
Merged

feat: removed -no-snapshot-load and added -no-window #117

gmegidish merged 1 commit into from
Nov 26, 2025

Conversation

@gmegidish
Copy link
Member

@gmegidish gmegidish commented Nov 26, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Modified Android emulator startup to run without a GUI window.

✏️ Tip: You can customize this high-level summary in your review settings.

@gmegidish gmegidish merged commit 5d9985b into main Nov 26, 2025
3 of 4 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The emulator launch flag in AndroidDevice.Boot was changed from -no-snapshot-load to -no-window, altering the Android emulator startup to run without a GUI window instead of skipping snapshot loading.

Changes

Cohort / File(s) Summary
Android Emulator Startup Flag
devices/android.go		 Changed emulator launch flag from -no-snapshot-load to -no-window in boot sequence

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the -no-window flag is the intended behavior change and compatible with the emulator configuration
  • Check that existing tests account for headless emulator execution
  • Confirm this change doesn't break snapshot management or other boot-time functionality

Poem

🐰 No window to see, just the code running free,
The emulator boots headless, no GUI to flee,
One flag swapped out, so simple and neat,
A rabbit's small change makes the startup complete! 🚀

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-launch-emulator-with-no-window
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8cd12f5 and ba5005d.

📒 Files selected for processing (1)
  • devices/android.go (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot mentioned this pull request Dec 10, 2025
Merged
@gmegidish gmegidish deleted the feat-launch-emulator-with-no-window branch December 14, 2025 19:31
@coderabbitai coderabbitai bot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmegidish