Merged
Conversation
Member
|
how big are all the files you added? you made it as small as possible? if so +1 for MRG. thx @fraimondo |
Contributor
Author
|
Its 30 seconds at 100 Hz, a few channels, with an EDF file exported for comparison. Is this ok? |
Member
|
1.2MB is small. Ok for me. Ready to merge? |
Contributor
Author
|
I’m ready for step 4.
… On 9 May 2019, at 17:04, Alexandre Gramfort ***@***.***> wrote:
1.2MB is small. Ok for me. Ready to merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABCJDA7O4FKWWWJ3456J373PUQ4QNANCNFSM4HLYIUTQ>.
|
Member
|
step 4?
|
Contributor
Author
|
"4. Once your PR is merged, ask a maintainer to cut a new release of the testing data, e.g. 0.53."
After I have to do the PR in MNE
… On 9 May 2019, at 17:08, Alexandre Gramfort ***@***.***> wrote:
step 4?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is testing data for a Nihon Kohden native reader. Includes an exported EDF.