Merged
Conversation
This was referenced Jun 29, 2024
Member
|
Looks good, in it goes and you can then work on interaction! |
mscheltienne
reviewed
Jul 2, 2024
| ch_spinbox.setDecimals(3) | ||
| ch_spinbox.setValue(self.mne.scalings[ch] * self.mne.unit_scalings[ch]) | ||
| ch_spinbox.setDisabled(True) | ||
| # ch_spinbox.setReadOnly(True) |
Member
There was a problem hiding this comment.
Could you remove this comment if the command is unused in one of the follow-up PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing a pull request! Please make sure you have read the
contribution guidelines
before submitting.
Please be aware that we are a loose team of volunteers so patience is
necessary. Assistance handling other issues is very welcome. We value all user
contributions, no matter how minor they are. If we are slow to review, either
the pull request needs some benchmarking, tinkering, convincing, etc. or more
likely the reviewers are simply busy. In either case, we ask for your
understanding during the review process.
Again, thanks for contributing!
Reference issue
#230 , mne-tools/mne-python#10888 , #212
What does this implement/fix?
Adds to the Settings dialogue to display channel scalings and channel units
Currently the spinboxes can't be edited and will not be able to until a following PR. Let me know if they style of the groupbox containing the channel scalings should change (such as putting units after the spinbox)
Additional information
This is the first of 4 or 5 PRs to allow display and scaling of channel types based on sensor units and monitor resolution and size