Make Info inherit from Bunch.#9757
Closed
mscheltienne wants to merge 0 commit intomne-tools:mainfrom
mscheltienne:info_to_bunch
Closed
Make Info inherit from Bunch.#9757mscheltienne wants to merge 0 commit intomne-tools:mainfrom mscheltienne:info_to_bunch
mscheltienne wants to merge 0 commit intomne-tools:mainfrom
mscheltienne:info_to_bunch
Conversation
Member
Author
|
Notes following those 2 very quick tests: it doesn't look to me like it's going to be a pain to add. Bunch from MNE
Bunch from scikit-learn:
I will pick this up next week! |
Member
Author
|
Messed up CLI GitHub while reverting the 2 test changes.. Opening a new PR with dictionary keys exposed as attributes working for mne.Info as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #9752; a quick test of what would break if we change Info from a dict to a Bunch.
I gave it a quick test and the
copy()method fails.copy.deepcopy()doesn't bring the set attributes and raisesAttributeError: 'Info' object has no attribute 'ch_names'. Let's see if anything else breaks.For the
copy()method, one quick solution would be to leave the only propertych_namesin the code as it is now, but I think it might bite us later on.If not too much code breaks, let's put some more thoughts into
Bunchand how to copy it to make sure it will work as intended.