[MRG] Add units parameter to get_data for Epochs#9553
Merged
larsoner merged 15 commits intomne-tools:mainfrom Jul 15, 2021
Merged
[MRG] Add units parameter to get_data for Epochs#9553larsoner merged 15 commits intomne-tools:mainfrom
units parameter to get_data for Epochs#9553larsoner merged 15 commits intomne-tools:mainfrom
Conversation
sappelhoff
commented
Jul 12, 2021
units parameter to get_data for Epochsunits parameter to get_data for Epochs
2 tasks
11 tasks
Member
Author
|
@HanBnrd perhaps you want to review this PR, as it builds on the stuff you coded during the last sprint :-) |
larsoner
reviewed
Jul 13, 2021
Contributor
Thanks for implementing this @sappelhoff! Just went through the code, looks good to me 🙂 |
HanBnrd
reviewed
Jul 13, 2021
sappelhoff
commented
Jul 15, 2021
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
…-python into enh/get_data/units_epochs Co-authored-by: Johann Benerradi <johann.benerradi@gmail.com>
sappelhoff
commented
Jul 15, 2021
larsoner
reviewed
Jul 15, 2021
Member
larsoner
left a comment
There was a problem hiding this comment.
Other than a couple of minor simplification ideas, LGTM!
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
larsoner
approved these changes
Jul 15, 2021
Member
|
Thanks @sappelhoff ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8473
Follow up to #9136
Adds the
unitsparameter to theget_datamethod ofEpochs.Work in ProgressTo do