Skip to content

Update download URL to pyvista main branch#9497

Merged
cbrnr merged 2 commits intomne-tools:mainfrom
cbrnr:fix-circleci-pyvista
Jun 22, 2021
Merged

Update download URL to pyvista main branch#9497
cbrnr merged 2 commits intomne-tools:mainfrom
cbrnr:fix-circleci-pyvista

Conversation

@cbrnr
Copy link
Copy Markdown
Contributor

@cbrnr cbrnr commented Jun 22, 2021

Because they changed master to main the download URL isn't working anymore (used in our CircleCI).

@cbrnr cbrnr requested a review from GuillaumeFavelier June 22, 2021 14:17
@GuillaumeFavelier
Copy link
Copy Markdown
Contributor

Thanks for starting this @cbrnr !

Not only tools/circleci_dependencies.sh but also tools/azure_dependencies.sh and tools/github_actions_dependencies.sh need to be modified.

I pushed 0731e84

Copy link
Copy Markdown
Contributor

@GuillaumeFavelier GuillaumeFavelier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge when the CIs return happy

@cbrnr cbrnr merged commit 0af111f into mne-tools:main Jun 22, 2021
@cbrnr cbrnr deleted the fix-circleci-pyvista branch June 22, 2021 16:17
@cbrnr
Copy link
Copy Markdown
Contributor Author

cbrnr commented Jun 22, 2021

All green except for pip pre. Thanks @GuillaumeFavelier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants