[MRG, ENH] Change the sEEG tutorial to support new data#9478
[MRG, ENH] Change the sEEG tutorial to support new data#9478larsoner merged 12 commits intomne-tools:mainfrom
Conversation
|
Ok this should be good to go once the CIs pass! |
|
The artifact looks good |
|
this part is not formatted right: |
Good catch! I was too focused on the plots turning out alright. |
|
Ok fixed the note and my other note that I modeled it off that was also a mistake... oops |
agramfort
left a comment
There was a problem hiding this comment.
besides LGTM
thx @alexrockhill
|
|
||
| print(__doc__) | ||
|
|
||
| np.set_printoptions(suppress=True) # suppress scientific notation |
There was a problem hiding this comment.
I'm okay with having this, but we need to update reset_warnings to np.set_printoptions to whatever they are when conf.py is initially loaded (which can be obtained before any examples are run directly in conf.py using get_printoptions presumably)
There was a problem hiding this comment.
I have a hard time understanding the affines in scientific notation. I'm not sure what you mean @larsoner, is that just like putting it back at the end?
Also that's how nibabel does it and it looks nice.
|
I'll push a quick commit |
|
Well I get what you did I think but I'm definitely glad you did it :) Thanks |
|
Go go go @alexrockhill ! |
Address new data in mne-tools/mne-misc-data#5.
Ok, there is a bit of an issue with the coordinate transforms that I am still working out, but I think everything otherwise is okay.