MRG, MAINT: Better split of reqs#9337
Merged
drammock merged 2 commits intomne-tools:mainfrom Apr 22, 2021
Merged
Conversation
drammock
approved these changes
Apr 22, 2021
Member
drammock
left a comment
There was a problem hiding this comment.
LGTM, seems like an improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #9192 I think we need a little bit more granularity in our test infrastructure, so:
ipytest, it was errantly addedrequirements_testing_extra.txtrequirements_*files to make it clearer why we have/need themazure-pipelines.ymlto include therequirements_testing_extra.txtinstallsOverall I hope this makes things a bit more DRY and well defined. @drammock I know you've been disappointed with the structure of our requirements, can you see if you think this at least helps instead of making things worse?