Skip to content

FIX: Brain locale#9179

Merged
GuillaumeFavelier merged 1 commit intomne-tools:mainfrom
GuillaumeFavelier:fix/brain_locale
Mar 22, 2021
Merged

FIX: Brain locale#9179
GuillaumeFavelier merged 1 commit intomne-tools:mainfrom
GuillaumeFavelier:fix/brain_locale

Conversation

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Mar 22, 2021

This small PR fixes the issue with Brain locale.

master PR
image image

It's an item of #7162

@GuillaumeFavelier GuillaumeFavelier self-assigned this Mar 22, 2021
@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

GuillaumeFavelier commented Mar 22, 2021

Feel free to try it @hoechenberger, @agramfort 👍

@hoechenberger
Copy link
Copy Markdown
Member

hoechenberger commented Mar 22, 2021

Perfect, thanks!

@GuillaumeFavelier GuillaumeFavelier merged commit 75a408e into mne-tools:main Mar 22, 2021
@GuillaumeFavelier GuillaumeFavelier deleted the fix/brain_locale branch March 22, 2021 11:18
@larsoner
Copy link
Copy Markdown
Member

larsoner commented Mar 22, 2021

Am I remembering correctly that the colorbar has the same problem on your system? Did this fix that as well, or do we need a fix on the VTK end for that?

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

GuillaumeFavelier commented Mar 22, 2021

the colorbar has the same problem on your system?

Yes I just noticed. I don't know a fix for that except playing with my env variables.

@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Mar 22, 2021
Closed
86 tasks
@larsoner
Copy link
Copy Markdown
Member

larsoner commented Mar 22, 2021 •
edited
Loading

Can you try doing QLocale.setDefault(QLocale.c()) at the first import of Qt (before any other VTK windows / applications are created)? It's not the right solution to change the global state like this (at least not without setting it back), but it would at least tell us if it's perhaps the Qt global state change breaking things in VTK:

https://gitlab.kitware.com/vtk/vtk/-/issues/17660

Also can you see if you have this problem in a VTK / PyVista scalarbar example that does not use Qt? It would help us isolate the problem to VTK+Qt instead of VTK alone as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hoechenberger hoechenberger hoechenberger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeFavelier @hoechenberger @larsoner