ENH: Extend _repr_html_ method for Raw by vagechirkov · Pull Request #9172 · mne-tools/mne-python

vagechirkov · 2021-03-20T08:41:03Z

Reference issue #6846 and PR #9161

Add more information in the _repr_html_ output.

agramfort · 2021-03-20T08:49:59Z

I would just show the basenames of the filenames and represent the measurement time range in hour / min / seconds

…

vagechirkov · 2021-03-20T09:21:04Z

I would just show the basenames of the filenames and represent the measurement time range in hour / min / seconds
…

Here is an example:

mne/io/base.py

hoechenberger · 2021-03-20T12:09:47Z

Can we get rid of the "Raw" title? I believe it's unnecessary.

hoechenberger · 2021-03-20T12:11:00Z

"Measurement date" should ideally include the time too :)

mne/data/html_templates.py

Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>

…/mne-python into pr/vagechirkov/9172

vagechirkov · 2021-03-20T12:29:15Z

"Measurement date" should ideally include the time too :)

hoechenberger · 2021-03-20T12:35:18Z

Much better!

I haven't looked at the generated HTML code, but I have the impression that there's either another line
break or empty row now before the first one actually containing data:

Do you think this could be improved easily?

mne/data/html_templates.py

hoechenberger · 2021-03-20T12:41:01Z

mne/data/html_templates.py

+        <td>{{', '.join(filenames)}}</td>
+    </tr>
    <tr>
        <th>Measurement time range</th>


Do you think we could change this to simply "Measurement time"? Would be slightly more concise … @agramfort WDYT?

Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>

vagechirkov · 2021-03-20T12:58:20Z

Much better!

I haven't looked at the generated HTML code, but I have the impression that there's either another line
break or empty row now before the first one actually containing data:

Do you think this could be improved easily?

I think I've fixed this now :)

hoechenberger · 2021-03-20T13:05:56Z

Cool, looking good!

agramfort · 2021-03-21T09:07:32Z

regarding measurement time range I would rather show the duration eg (6min 13s or 8h 2min 28s). For example a sleep recording can last 10h hours and it would be spanned over different days.

hoechenberger · 2021-03-21T09:17:44Z

regarding measurement time range I would rather show the duration eg (6min 13s or 8h 2min 28s). For example a sleep recording can last 10h hours and it would be spanned over different days.

So you're proposing

Duration      12:34:56 (hh:mm:ss)

?

I like this.

Also wondering if we should maybe include info['subject_info']['his_id'] as well, if present:

Participant      Mrs X

agramfort · 2021-03-21T09:30:55Z

Yes and yes 👍

vagechirkov · 2021-03-21T14:06:57Z

agramfort

LGTM provided you manage to make CIs green

agramfort · 2021-03-21T17:47:46Z

Thx @vagechirkov

hoechenberger · 2021-03-21T17:59:56Z

This is a real usability improvement, thanks a bunch!!

vagechirkov · 2021-03-21T18:18:25Z

This is a real usability improvement, thanks a bunch!!

Do you think it makes sense to create similar HTML-based representations for other MNE-Python objects?

hoechenberger · 2021-03-21T18:27:02Z

This is a real usability improvement, thanks a bunch!!

Do you think it makes sense to create similar HTML-based representations for other MNE-Python objects?

I was actually thinking about exactly this, yes. Most relevant for me personally would be Epochs and Evoked; but having such a nice representation for more objects eventually could make total sense!!

vagechirkov · 2021-03-21T18:56:26Z

This is a real usability improvement, thanks a bunch!!

Do you think it makes sense to create similar HTML-based representations for other MNE-Python objects?

I was actually thinking about exactly this, yes. Most relevant for me personally would be Epochs and Evoked; but having such a nice representation for more objects eventually could make total sense!!

Alright, I can do this. I would create a new issue for several objects to keep progress :)

agramfort · 2021-03-21T19:22:15Z

+1 for evoked and epochs

add filenames field

8d477ac

vagechirkov added 2 commits March 20, 2021 10:01

full path to basename

8cbdcb6

Update time format

26a3852

hoechenberger reviewed Mar 20, 2021

View reviewed changes

mne/io/base.py Outdated Show resolved Hide resolved

mne/io/base.py Outdated Show resolved Hide resolved

update f-strings

e207f5c

hoechenberger reviewed Mar 20, 2021

View reviewed changes

mne/data/html_templates.py Outdated Show resolved Hide resolved

delete captions

eaa1b74

hoechenberger reviewed Mar 20, 2021

View reviewed changes

mne/data/html_templates.py Outdated Show resolved Hide resolved

vagechirkov and others added 4 commits March 20, 2021 13:15

Update mne/data/html_templates.py

b6e7fe9

Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>

Update mne/data/html_templates.py

fe0ef06

Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>

Merge branch 'extend-repr-html-raw' of https://github.com/vagechirkov…

d935d30

…/mne-python into pr/vagechirkov/9172

add time to measurement date

e90c3fb

vagechirkov marked this pull request as ready for review March 20, 2021 12:33

vagechirkov changed the title ~~WIP ENH: Extend _repr_html_ method for Raw~~ ENH: Extend _repr_html_ method for Raw Mar 20, 2021

hoechenberger reviewed Mar 20, 2021

View reviewed changes

mne/data/html_templates.py Outdated Show resolved Hide resolved

hoechenberger reviewed Mar 20, 2021

View reviewed changes

vagechirkov and others added 2 commits March 20, 2021 13:55

update caption

ebfe435

Update mne/data/html_templates.py

08836e5

Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>

add subject_info and duration

15040a4

hoechenberger approved these changes Mar 21, 2021

View reviewed changes

agramfort approved these changes Mar 21, 2021

View reviewed changes

time zone back to GMT

ddd7600

agramfort merged commit 1e403b2 into mne-tools:main Mar 21, 2021

vagechirkov deleted the extend-repr-html-raw branch March 21, 2021 18:08

vagechirkov mentioned this pull request Mar 21, 2021

Jupyter Notebook representations of MNE objects #9177

Closed

5 tasks

rob-luke mentioned this pull request May 2, 2021

MRG: Add fNIRS to html output #9367

Merged

Uh oh!

Conversation

vagechirkov commented Mar 20, 2021

Uh oh!

agramfort commented Mar 20, 2021 via email

Uh oh!

vagechirkov commented Mar 20, 2021

Uh oh!

Uh oh!

Uh oh!

hoechenberger commented Mar 20, 2021

Uh oh!

hoechenberger commented Mar 20, 2021

Uh oh!

Uh oh!

Uh oh!

vagechirkov commented Mar 20, 2021

Uh oh!

hoechenberger commented Mar 20, 2021

Uh oh!

Uh oh!

hoechenberger Mar 20, 2021

Choose a reason for hiding this comment

Uh oh!

vagechirkov commented Mar 20, 2021

Uh oh!

hoechenberger commented Mar 20, 2021

Uh oh!

agramfort commented Mar 21, 2021

Uh oh!

hoechenberger commented Mar 21, 2021

Uh oh!

agramfort commented Mar 21, 2021 via email

Uh oh!

vagechirkov commented Mar 21, 2021

Uh oh!

agramfort left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agramfort commented Mar 21, 2021

Uh oh!

hoechenberger commented Mar 21, 2021

Uh oh!

vagechirkov commented Mar 21, 2021

Uh oh!

hoechenberger commented Mar 21, 2021

Uh oh!

vagechirkov commented Mar 21, 2021

Uh oh!

agramfort commented Mar 21, 2021 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

agramfort left a comment •

edited

Loading