Fixed length epochs overlap#9096
Merged
wmvanvliet merged 9 commits intomne-tools:mainfrom Mar 18, 2021
Merged
Conversation
agramfort
reviewed
Mar 16, 2021
e234d91 to
b8282d0
Compare
agramfort
reviewed
Mar 16, 2021
agramfort
reviewed
Mar 16, 2021
agramfort
approved these changes
Mar 17, 2021
Member
agramfort
left a comment
There was a problem hiding this comment.
can we just add a what's new entry?
thx @sfc-neuro !
Member
|
@sfc-neuro can you quickly push a what's new entry so we can move on here? thanks |
…n and written the consequent test in test_epochs
1bb7724 to
1af0432
Compare
Contributor
|
Thanks @sfc-neuro! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #8773.
What does this implement/fix?
Adds compatibility for the overlap parameter in the function make_fixed_length_epochs
Additional information
Tests were also added to test the new feature inspired by the pre-existing ones written for make_fixed_length_events.