WIP: Prototype of MultiPlotter#8997
WIP: Prototype of MultiPlotter#8997GuillaumeFavelier wants to merge 34 commits intomne-tools:mainfrom
Conversation
|
I would add to this list, if we haven't done it already:
|
|
Done in here on this PR: mne-python/mne/viz/backends/_pyvista.py Lines 82 to 83 in f20f816 |
|
Update after dd0d67d (with experimental I see the main challenges being 1) ensuring correct size and 2) managing picking nicely for all the viewers |
|
Can you check to make sure volumetric rendering looks okay? Just want to make sure it plays nicely with the ambient occlusion etc. |
|
It's better after #9121 |
|
This PR now requires pyvista/pyvistaqt#90. I plan to move the |
|
In my experiments, the
This is how it looks locally: Probably the margins can be nullified. |
|
Agreed docking is useful, can that be a first PR, separate from the MultiPlotter stuff? It seems orthogonal, easier to review, and will get in sooner than if we tie it into this PR |
|
Circle does not seem ready yet. I'll investigate locally: |
|
Closing for now. It already served the purpose of refactor |






I have been experimenting with the new PyVistaQt class MultiPlotter to bring proper SSAO and/or EDL to MNE on #8771 (comment) (among other features like multiple toolbars, menu bars and multi-renderers). And I don't think it's reasonable to do that in one go.
This PR is far from being mergeable but I believe it could drive smaller PRs that can help with 3d backend refactoring in general. For instance:
showRendererbindings foradd_meshandadd_actorself.interactorinBrainself.plotterinBrainand useself._rendererinsteadself.plotterin_Rendererand useself.figureinstead